[Cocci] Unwanted empty lines
w.sang at pengutronix.de
Tue Mar 30 11:11:09 CEST 2010
On Tue, Mar 30, 2010 at 07:34:13AM +0200, Julia Lawall wrote:
> > PS: Would it be acceptable to extend the syntax of -inplace to be similar to
> > sed (making backups optional)? Something like this:
> > -inplace[=SUFFIX]
> > edit files in place (makes backup if extension supplied)
> > Having git, I'd like to drop them as backups are not needed but they make 'git
> > status' a bit messy.
> Should I worry that someone out there is relying on the backup
> functionality, and that that person is going to install a new version of
> Coccinelle without looking at the list of changes?
Yeah, that would be user-friendly.
> I could print a warning?
In the worst case, someone not looking at the list of changes will also not
read the warnings?
> Or only have no backup if there is a .git directory in the directory provided
> with the -dir option?
There are too many SCM around to use heuristic IMHO.
> Or make the change and hope for the best?
How large is the user-base? That makes a probability of... nah, just kidding.
About the renaming: If you rename to '-in-place' you would be even more
sed-compatible ;) Maybe this name (and keeping the old for compatibility for a
few versions) will do?
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: Digital signature
Url : http://lists.diku.dk/pipermail/cocci/attachments/20100330/b1f22644/attachment.pgp
More information about the Cocci